Skip to content

Commit ece1b21

Browse files
Nemo157Joshua Nelson
authored and
Joshua Nelson
committed
Log errors while marking crates yanked
1 parent 2dab8c5 commit ece1b21

File tree

1 file changed

+17
-7
lines changed

1 file changed

+17
-7
lines changed

src/docbuilder/queue.rs

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,24 @@ impl DocBuilder {
2222
for krate in &changes {
2323
match krate.kind {
2424
ChangeKind::Yanked => {
25-
// FIXME: remove built doc files? set build as failed?
26-
conn.execute(
27-
"UPDATE releases SET yanked = TRUE FROM crates WHERE \
28-
crates.id = releases.crate_id AND name = $1 AND version = $2",
25+
let res = conn.execute(
26+
"
27+
UPDATE releases
28+
SET yanked = TRUE
29+
FROM crates
30+
WHERE crates.id = releases.crate_id
31+
AND name = $1
32+
AND version = $2
33+
",
2934
&[&krate.name, &krate.version],
30-
)
31-
.ok();
32-
debug!("{}-{} yanked", krate.name, krate.version);
35+
);
36+
match res {
37+
Ok(_) => debug!("{}-{} yanked", krate.name, krate.version),
38+
Err(err) => error!(
39+
"error while setting {}-{} to yanked: {}",
40+
krate.name, krate.version, err
41+
),
42+
}
3343
}
3444
ChangeKind::Added => {
3545
let priority = get_crate_priority(&conn, &krate.name)?;

0 commit comments

Comments
 (0)