Skip to content

Use full page width for Header and Footer components #3681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2021
Merged

Use full page width for Header and Footer components #3681

merged 3 commits into from
Jun 8, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jun 6, 2021

This PR removes the width-limit from the header and footer on all pages. This will allow us to use wider layouts in the future for certain pages that would benefit from having more space (e.g. crate details page).

The PR also refactors the Header component at the same time to use a CSS grid to get rid of the duplicate search form.

Bildschirmfoto 2021-06-06 um 11 47 31

Bildschirmfoto 2021-06-06 um 11 47 22

Bildschirmfoto 2021-06-06 um 11 47 14

Bildschirmfoto 2021-06-06 um 11 47 00

Bildschirmfoto 2021-06-06 um 11 46 47

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Jun 6, 2021
@pichfl
Copy link

pichfl commented Jun 8, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Jun 8, 2021

📌 Commit e5264e9 has been approved by pichfl

@bors
Copy link
Contributor

bors commented Jun 8, 2021

⌛ Testing commit e5264e9 with merge 529c446...

@bors
Copy link
Contributor

bors commented Jun 8, 2021

☀️ Test successful - checks-actions
Approved by: pichfl
Pushing 529c446 to master...

@bors bors merged commit 529c446 into rust-lang:master Jun 8, 2021
@bors bors mentioned this pull request Jun 8, 2021
Closed
@Turbo87 Turbo87 deleted the big-head branch June 8, 2021 08:36
@wangkirin wangkirin mentioned this pull request Jun 9, 2021
Closed
@Turbo87 Turbo87 mentioned this pull request Jun 11, 2021
Merged
bors added a commit that referenced this pull request Jun 11, 2021
@bors
Auto merge of #3696 - rust-lang:revert-3681-big-head, r=pietroalbini
32e705e 
Revert "Use full page width for `Header` and `Footer` components"

Reverts #3681

Closes #3687

r? `@pietroalbini`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@locks locks

@pichfl pichfl

Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Turbo87 @pichfl @bors @locks @rust-highfive