Support dark mode #3585
Support dark mode #3585
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
unfortunately such large scale changes to the design are currently considered problematic by the webpresence subteam 😞 |
Turbo87
added
A-frontend 🐹
C-enhancement ✨
|
Can you explain what's problematic about this change? It's a big accessibility win. I never use crates.io because it doesn't support dark mode. What's needed to move this forward? |
|
we've discussed this PR in the weekly crates.io team meeting today and we're generally not against implementing a dark mode and we would like to move this forward. we still need to figure out a few details though and we would like to hide this behind some kind of feature flag for now. once we have a more detailed plan on how we want to approach this I'll let you know. |
|
☔ The latest upstream changes (presumably #3681) made this pull request unmergeable. Please resolve the merge conflicts. |
Ping @wyhaya |
|
☔ The latest upstream changes (presumably #3878) made this pull request unmergeable. Please resolve the merge conflicts. |
Replace "Toggle Design" button with new `/settings/appearance` route Just like the "Toggle Design" button before, this route is only visible in development mode, or to be more precise: the link to this route is only visible in development mode, so that we can test this out in production too. This should be seen as a first step towards implementing a "dark color scheme" mode (see #3585), roughly inspired by how GitHub has implemented it in their user settings. <img width="1000" alt="Bildschirmfoto 2021-12-26 um 19 34 12" src="https://user-images.githubusercontent.com/141300/147417178-16083d7d-6f57-47e0-b980-820ee5af1acf.png">
|
the short version is: we're working on it 😉 |
|
Is there any progress being made towards making this a reality? I'm finding that it isn't possible for me to use crates.io for long periods of time without getting searing headaches 🥲 |
|
If there was any progress, it would be posted to this issue. |
|
And as always, Dark Reader. |
Unfortunately, JonathanHelianthicusDoe's PR has closed. Other relevant links: - rust-lang/crates.io#4348 - rust-lang/crates.io#3585
|
Looks like deleting the target branch automatically closed this, so it will have to be reopened against |
|
Huh, that was definitely not supposed to happen. The target branch should've been updated without the pull request getting closed. 🤨 But I also can't find the fork from which the PR was created, so maybe that's what why this PR got closed instead of updated. |
|
Hopefully we can avoid losing track of this. @wyhaya would you be willing to recreate the branch? |
|
Hi @fenhl I inadvertently deleted the fork of this repository, and unfortunately I can't recreate the branch. The best I can think of is to copy the code line by line from this PR. This PR submission is more than two years old and is probably no longer appropriate for crates.io. The CSS code in it is poorly written and I think a rewrite might be a good idea. |
|
It is still possible to recover the code using the github cli: |
Preview:
567.mp4
Related: #3489