-
Notifications
You must be signed in to change notification settings - Fork 30
Unsafe host-specific bindings #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree with you, we should likely deprecate it in Core and remove it from stdlib. |
tsnobip
added a commit
to rescript-lang/rescript
that referenced
this issue
Mar 12, 2025
tsnobip
added a commit
to rescript-lang/rescript
that referenced
this issue
Mar 12, 2025
tsnobip
added a commit
to rescript-lang/rescript
that referenced
this issue
Mar 12, 2025
tsnobip
added a commit
to rescript-lang/rescript
that referenced
this issue
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have this in the
Core
module.(ref: https://github.com/rescript-association/rescript-core/blob/22642ea/src/RescriptCore.res#L47-L49)
However, using
window
anddocument
is not safe becauseJs.globalThis
object binding rescript#6909 (comment)globalThis
.I also think that the compiler and the Core should not promote specific hosts.
window
&document
are part of the HTML and has nothing to do with Node.js.global
is Node.js specific and has nothing to do with browsers.IMO Core should delegate bindings to third-parties (e.g. rescript-webapi) and keep the representation in JavaScript itself.
The text was updated successfully, but these errors were encountered: