Skip to content

Commit e15a2b4

Browse files
committed
deprecate unsafe host-specific bindings from stdlib
Fixes rescript-lang/rescript-core#240
1 parent 1d8560f commit e15a2b4

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232

3333
- Deprecate JSON.Classify.classify. https://github.com/rescript-lang/rescript/pull/7315
3434
- Hide stdlib modules in output. https://github.com/rescript-lang/rescript/pull/7305
35+
- Deprecate unsafe host-specific bindings from stdlib. https://github.com/rescript-lang/rescript/pull/7334
3536

3637
#### :bug: Bug fix
3738

lib/es6/Stdlib.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function assertEqual(a, b) {
1111
RE_EXN_ID: "Assert_failure",
1212
_1: [
1313
"Stdlib.res",
14-
117,
14+
120,
1515
4
1616
],
1717
Error: new Error()

lib/js/Stdlib.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function assertEqual(a, b) {
1111
RE_EXN_ID: "Assert_failure",
1212
_1: [
1313
"Stdlib.res",
14-
117,
14+
120,
1515
4
1616
],
1717
Error: new Error()

runtime/Stdlib.res

+3
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,11 @@ type null<+'a> = Primitive_js_extern.null<'a>
5353
type undefined<+'a> = Primitive_js_extern.undefined<'a>
5454
type nullable<+'a> = Primitive_js_extern.nullable<'a>
5555

56+
@deprecated("Use rescript-webapi instead")
5657
@val external window: Dom.window = "window"
58+
@deprecated("Use rescript-webapi instead")
5759
@val external document: Dom.document = "document"
60+
@deprecated("Use rescript-webapi instead")
5861
@val external globalThis: {..} = "globalThis"
5962

6063
/**

0 commit comments

Comments
 (0)