Add csv.__version__
#7357
Merged
Add csv.__version__
#7357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Feb 22, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
I still would prefer if |
I get that, but I feel like it's a CPython bug rather than a typeshed bug if the |
|
Because it starts with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously discussed this in #6398, and decided not to include it in the stub. However, it is declared as a publicly exported object in the module's
__all__at runtime, so not including it in the stub creates an inconsistency in the stub's__all__(see #7356). Moreover, there doesn't really seem to be any harm in adding it to the stub. So, I think we should add it.