Skip to content

Increase pyright strictness when checking __all__ #7356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 2, 2022
Merged

Increase pyright strictness when checking __all__ #7356

merged 20 commits into from
Mar 2, 2022

Conversation

AlexWaygood
Copy link
Member

And also fix a typo in pyrightconfig.stricter.json that was already fixed in pyrightconfig.json in #7355

@AlexWaygood AlexWaygood mentioned this pull request Feb 22, 2022
Merged
@github-actions

This comment has been minimized.

Sign in to view
This was referenced Feb 22, 2022
Merged
Merged
Merged
Merged
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood
Copy link
Member Author

@srittau, could you possibly take a look at the Redis hit picked up here? (I can have a go, if not — but you know much more about Redis than I do 🙂)

@AlexWaygood AlexWaygood mentioned this pull request Feb 23, 2022
Merged
@srittau
Copy link
Collaborator

srittau commented Feb 23, 2022 •
edited
Loading

@AlexWaygood Looking at the source code, RedisCluster needs to be re-exported from .cluster in the stubs.

Edit: I can create a separate PR if you wish.

@AlexWaygood
Copy link
Member Author

I can create a separate PR if you wish.

Yes please 🙂

@srittau
Copy link
Collaborator

srittau commented Feb 23, 2022

#7371

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Feb 27, 2022 •
edited
Loading

I'm going to mark this as "ready for review", as it's nearly mergeable. There are two remaining blockers:

  • Delete the contents of distutils.command.__init__ #7370
  • Popen is listed in asyncio.windows_utils.__all__, but is not currently defined in the stub. I'd submit a patch to add it to the stub, but I've looked at the source code 5 times now and still have no idea how the class is meant to work or how it should be typed. Any help on that one would be appreciated!

@AlexWaygood AlexWaygood marked this pull request as ready for review February 27, 2022 17:52
@JelleZijlstra JelleZijlstra mentioned this pull request Feb 28, 2022
Merged
srittau
srittau approved these changes Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once CI clears.

@AlexWaygood AlexWaygood mentioned this pull request Mar 1, 2022
Merged
@AlexWaygood
Copy link
Member Author

AlexWaygood commented Mar 1, 2022 •
edited
Loading

(#7412 is a new blocker now that #7343 has been merged...)

EDIT: #7412 has now been merged :)

@AlexWaygood
Copy link
Member Author

Aaand CI is finally green! 🥳🥳🥳

hauntsaninja
hauntsaninja approved these changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@hauntsaninja hauntsaninja merged commit 39c8202 into python:master Mar 2, 2022
@AlexWaygood AlexWaygood deleted the pyright-all branch March 2, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexWaygood @srittau @hauntsaninja