Skip to content

Yet another readOnly and writeOnly support #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 17, 2020

Conversation

phrfpeixoto
Copy link
Contributor

@phrfpeixoto phrfpeixoto commented Jul 14, 2019

It seems I miserably failed to search ahead of writing all this code, so I did not know that #52 or #135
Yet, since I've written all this, I might as well post it here.

This is an implementation of readOnly and writeOnly support.

Fixes #52

@codecov
Copy link

codecov bot commented Jul 14, 2019

Codecov Report

Merging #152 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #152      +/-   ##
=========================================
+ Coverage   96.12%   96.2%   +0.08%     
=========================================
  Files         114     115       +1     
  Lines        2191    2239      +48     
=========================================
+ Hits         2106    2154      +48     
  Misses         85      85
Impacted Files Coverage Δ
openapi_core/validation/response/validators.py 89.01% <100%> (+0.12%) ⬆️
openapi_core/unmarshalling/schemas/factories.py 100% <100%> (ø) ⬆️
...penapi_core/unmarshalling/schemas/unmarshallers.py 95.77% <100%> (+0.18%) ⬆️
openapi_core/schema_validator/_validators.py 93.22% <100%> (+3.22%) ⬆️
openapi_core/schema/schemas/models.py 98.36% <100%> (+0.05%) ⬆️
openapi_core/unmarshalling/schemas/enums.py 100% <100%> (ø)
openapi_core/schema_validator/validators.py 100% <100%> (ø) ⬆️
openapi_core/schema/schemas/factories.py 100% <100%> (ø) ⬆️
openapi_core/validation/request/validators.py 94.82% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6fdd64...1bea601. Read the comment docs.

@p1c2u p1c2u force-pushed the read_only_write_only branch from e04087d to 1bea601 Compare February 17, 2020 12:48
@p1c2u
Copy link
Collaborator

p1c2u commented Feb 17, 2020

@phrfpeixoto thank you for the contribution. Took awhile to combine this with new unmarshalling mechanism. LGTM

@p1c2u p1c2u merged commit 778b4a5 into python-openapi:master Feb 17, 2020
@phrfpeixoto phrfpeixoto deleted the read_only_write_only branch February 18, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

readOnly properties not supported
2 participants