Skip to content

Adding support for readOnly and writeOnly #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

badcure
Copy link
Contributor

@badcure badcure commented May 21, 2019

No description provided.

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #135 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #135     +/-   ##
=========================================
- Coverage   95.83%   95.73%   -0.1%     
=========================================
  Files          56       56             
  Lines        1538     1549     +11     
=========================================
+ Hits         1474     1483      +9     
- Misses         64       66      +2
Impacted Files Coverage Δ
openapi_core/schema/media_types/models.py 91.17% <100%> (+5.88%) ⬆️
openapi_core/schema/schemas/models.py 92.99% <100%> (+0.18%) ⬆️
openapi_core/validation/request/validators.py 100% <100%> (ø) ⬆️
openapi_core/schema/parameters/models.py 96.82% <100%> (ø) ⬆️
openapi_core/validation/response/validators.py 97.87% <100%> (ø) ⬆️
openapi_core/schema/schemas/factories.py 100% <100%> (ø) ⬆️
openapi_core/compat.py 55.55% <0%> (-44.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75840e0...709ce8c. Read the comment docs.

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #135 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   95.83%   96.12%   +0.28%     
==========================================
  Files          56       56              
  Lines        1538     1549      +11     
==========================================
+ Hits         1474     1489      +15     
+ Misses         64       60       -4
Impacted Files Coverage Δ
openapi_core/schema/media_types/models.py 91.17% <100%> (+5.88%) ⬆️
openapi_core/schema/schemas/models.py 92.99% <100%> (+0.18%) ⬆️
openapi_core/validation/request/validators.py 100% <100%> (ø) ⬆️
openapi_core/schema/parameters/models.py 96.82% <100%> (ø) ⬆️
openapi_core/validation/response/validators.py 97.87% <100%> (ø) ⬆️
openapi_core/schema/schemas/factories.py 100% <100%> (ø) ⬆️
openapi_core/schema/schemas/exceptions.py 86.53% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75840e0...d369076. Read the comment docs.

@badcure
Copy link
Contributor Author

badcure commented May 21, 2019

Note: I create #136 to address the CI failure. Python 3.4 is no longer supported, the final release was in April.

@badcure badcure closed this May 22, 2019
@badcure badcure reopened this May 22, 2019
@@ -109,6 +110,8 @@ def __init__(
if min_properties is not None else None
self.max_properties = int(max_properties)\
if max_properties is not None else None
self.read_only = read_only
self.write_only = write_only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows a given schema to be both readOnly and writeOnly at the same time.

@p1c2u
Copy link
Collaborator

p1c2u commented Feb 17, 2020

Closing the PR in favor of #152

@p1c2u p1c2u closed this Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants