-
-
Notifications
You must be signed in to change notification settings - Fork 135
Adding support for readOnly and writeOnly #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=========================================
- Coverage 95.83% 95.73% -0.1%
=========================================
Files 56 56
Lines 1538 1549 +11
=========================================
+ Hits 1474 1483 +9
- Misses 64 66 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 95.83% 96.12% +0.28%
==========================================
Files 56 56
Lines 1538 1549 +11
==========================================
+ Hits 1474 1489 +15
+ Misses 64 60 -4
Continue to review full report at Codecov.
|
Note: I create #136 to address the CI failure. Python 3.4 is no longer supported, the final release was in April. |
@@ -109,6 +110,8 @@ def __init__( | |||
if min_properties is not None else None | |||
self.max_properties = int(max_properties)\ | |||
if max_properties is not None else None | |||
self.read_only = read_only | |||
self.write_only = write_only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows a given schema to be both readOnly and writeOnly at the same time.
Closing the PR in favor of #152 |
No description provided.