Raw value type strict validation #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p1c2u
force-pushed
the
fix/raw-value-type-strict-validation
branch
from
11510f0 to
bf330ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=========================================
+ Coverage 96.19% 96.2% +0.01%
=========================================
Files 54 54
Lines 1444 1450 +6
=========================================
+ Hits 1389 1395 +6
Misses 55 55
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=========================================
+ Coverage 96.19% 96.3% +0.11%
=========================================
Files 54 54
Lines 1444 1460 +16
=========================================
+ Hits 1389 1406 +17
+ Misses 55 54 -1
Continue to review full report at Codecov.
|
p1c2u
force-pushed
the
fix/raw-value-type-strict-validation
branch
from
bf330ee to
9d1de1d
Compare
p1c2u
force-pushed
the
fix/raw-value-type-strict-validation
branch
from
9d1de1d to
cd0ca5d
Compare
sanderegg
reviewed
Apr 3, 2019
| return int(value) | ||
|
|
||
| def _unmarshal_number(self, value, custom_formatters=None, strict=True): | ||
| if strict and not isinstance(value, (float, )): |
There was a problem hiding this comment.
I have a case where I return a number with a value of 3
3 contrary to 3.0 is not recognized as a float.
bjmc
pushed a commit
to bjmc/openapi-core
that referenced
this pull request
Jun 12, 2019
…trict-validation Raw value type strict validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strict validation of raw value type.
Enabled for media type only. Parameters are disabled for now (backward compatibility). Parameters type strict validation should be enabled by default in version 1.0.
Fixes #105