validate type of casted value #113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
- Coverage 96.19% 95.85% -0.34%
==========================================
Files 54 54
Lines 1444 1449 +5
==========================================
Hits 1389 1389
- Misses 55 60 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=========================================
+ Coverage 96.19% 96.2% +0.01%
=========================================
Files 54 54
Lines 1444 1450 +6
=========================================
+ Hits 1389 1395 +6
Misses 55 55
Continue to review full report at Codecov.
|
|
Is there a chance this will be merged soon? |
|
yeah, would be nice to have this fixed! @p1c2u sorry for troubling you :) |
| @@ -238,8 +238,8 @@ def test_get_pets_ids_param(self, spec, response_validator): | |||
| host_url = 'http://petstore.swagger.io/v1' | |||
| path_pattern = '/v1/pets' | |||
| query_params = { | |||
| 'limit': '20', | |||
| 'ids': ['12', '13'], | |||
| 'limit': 20, | |||
There was a problem hiding this comment.
Query parameters are always passed as strings.
| @@ -782,10 +782,10 @@ def test_post_pets_raises_invalid_server_error(self, spec): | |||
| } | |||
| data = json.dumps(data_json) | |||
| headers = { | |||
| 'api_key': '12345', | |||
| 'api_key': 12345, | |||
There was a problem hiding this comment.
Headers are always passed as strings.
| } | ||
| cookies = { | ||
| 'user': '123', | ||
| 'user': 123, |
There was a problem hiding this comment.
Cookies are always passed as strings.
|
Closing in favor of #123 |
validation fixed, see #105