BUG: Fix yahoo options #244
Conversation
Pull from pydata/pandas-datareader
|
Hi, I apologize if this is not the correct channel for this note, I am new to Github. I've retrofitted some of the original Options code to work on nasdaq's options pages. Also working to do the same for Financial Statement data from zacks.com (BS, IS and SCF). I would love to contribute to this project, but am new to source control. Feel free to contact me at [email protected] with feedback or suggestions. Thank you all for developing such a great project. I am extremely impressed by the scope of data accessibility provided by datareader. Best, |
|
@beluga9 there are some (minor) flake8 errors see The command "nosetests -v --with-coverage --cover-package=pandas_datareader" exited with 0.
$ flake8 --ignore E501 pandas_datareader
pandas_datareader/yahoo/options.py:138:5: E303 too many blank lines (2)
pandas_datareader/yahoo/options.py:161:5: E303 too many blank lines (2)
pandas_datareader/yahoo/options.py:586:5: E303 too many blank lines (2)
pandas_datareader/yahoo/options.py:599:5: E303 too many blank lines (2)
pandas_datareader/yahoo/options.py:612:5: E303 too many blank lines (2)
pandas_datareader/yahoo/options.py:695:5: E303 too many blank lines (2)
pandas_datareader/yahoo/options.py:745:5: E303 too many blank lines (2)Could you fix them? That will be very nice. |
| ('Ask', 'ask', float), ('Chg', 'change', float), | ||
| ('PctChg', 'percentChange', float), ('Vol', 'volume', int), | ||
| ('Open_Int', 'openInterest', int), ('IV', 'impliedVolatility', float), | ||
| ('Last_Trade_Date', 'lastTradeDate', long)]: |
There was a problem hiding this comment.
long is not valid with Python 3
Maybe you might add
import pandas.compat as compat and use compat.long
There was a problem hiding this comment.
I just changed it to int as the long was not necessary.
|
👍 This is amazing! Thank you! |
|
If everyone is ok I will merge this great PR in the next coming days. |
|
Thanks! |
|
How can I upgrade to the latest version of pandas_datareader? I have run "pip install --upgrade pandas_datareader". If I run "import pandas_datareader as pd", "pd.version". I get '0.2.1'. |
|
Latest version of pandas_datareader is not published on Pypi. See https://github.com/pydata/pandas-datareader#install-latest-development-version |
|
Thank you |
This updates yahoo_options to use the json endpoint that's now in use by the Yahoo Finance site (Issue #212)
It adds the following columns to the existing list of columns:
Last_Trade_Date: the last trade datetimeJSON: a JSON object containing the raw json, which can be useful if additional data is needed that is not in the DataFrame's columns