Skip to content

API: Yahoo option type labels #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidastephens opened this issue Jan 8, 2017 · 3 comments
Closed

API: Yahoo option type labels #273

davidastephens opened this issue Jan 8, 2017 · 3 comments

Comments

@davidastephens
Copy link
Member

#244 changed how option types are described from put and call to puts and calls.

This is a breaking API change and is different than how the google option reader describes them.
Docs broken here

Any objection to changing this back to put and call? Semantically, as the index is referring to an individual option, I think the singular is more appropriate.

Example:

In [1]: 
from pandas_datareader import Options
tsla = Options('tsla', 'yahoo')
data = tsla.get_all_data()
data.index.levels[2]

Out[1]: 
Index(['calls', 'puts'], dtype='object', name='Type')

In [2]:
tsla = Options('tsla', 'google')
data = tsla.get_options_data(expiry=tsla.expiry_dates[0])
data.index.levels[2]
Out[2]:
Index(['call', 'put'], dtype='object', name='Type')

@femtotrader
Copy link
Contributor

Pinging @beluga9

@beluga9
Copy link
Contributor

beluga9 commented Jan 11, 2017

Sorry about that. No objections @davidastephens.

@davidastephens
Copy link
Member Author

No prob. Thanks, will modify and add tests to ensure consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants