Skip to content

Avoid unnecessary array allocation #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Data/Array/ST.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,14 @@ export const pushAll = function (as) {
};
};

export const push = function (a) {
return function (xs) {
return function () {
return xs.push(a);
};
};
};

export const shiftImpl = function (just) {
return function (nothing) {
return function (xs) {
Expand Down
11 changes: 5 additions & 6 deletions src/Data/Array/ST.purs
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ run st = ST.run (st >>= unsafeFreeze)
withArray
:: forall h a b
. (STArray h a -> ST h b)
-> Array a
-> ST h (Array a)
-> Array a
-> ST h (Array a)
withArray f xs = do
result <- thaw xs
_ <- f result
Expand Down Expand Up @@ -162,8 +162,7 @@ foreign import popImpl

-- | Append an element to the end of a mutable array. Returns the new length of
-- | the array.
push :: forall h a. a -> STArray h a -> ST h Int
push a = pushAll [a]
foreign import push :: forall h a. a -> STArray h a -> ST h Int

-- | Append the values in an immutable array to the end of a mutable array.
-- | Returns the new length of the mutable array.
Expand All @@ -176,7 +175,7 @@ foreign import pushAll
-- | Append an element to the front of a mutable array. Returns the new length of
-- | the array.
unshift :: forall h a. a -> STArray h a -> ST h Int
unshift a = unshiftAll [a]
unshift a = unshiftAll [ a ]

-- | Append the values in an immutable array to the front of a mutable array.
-- | Returns the new length of the mutable array.
Expand All @@ -191,7 +190,7 @@ modify :: forall h a. Int -> (a -> a) -> STArray h a -> ST h Boolean
modify i f xs = do
entry <- peek i xs
case entry of
Just x -> poke i (f x) xs
Just x -> poke i (f x) xs
Nothing -> pure false

-- | Remove and/or insert elements from/into a mutable array at the specified index.
Expand Down