Skip to content

Avoid unnecessary array allocation #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

i-am-the-slime
Copy link
Contributor

@i-am-the-slime i-am-the-slime commented Nov 16, 2022

Description of the change

Avoids reusing pushAll to implement push which saves on array allocations.

Closes #236


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@i-am-the-slime
Copy link
Contributor Author

Some accidental tidy formatting, but I think it's okay

@thomashoneyman
Copy link
Member

@i-am-the-slime If you're willing to resolve the conflicts with master I'm happy to take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement STArray.push via proper FFI
2 participants