Remove some usages of unsafeCoerce #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
kl0tl
force-pushed
the
no-unsafe-coerce
branch
from
405f4a3 to
0185609
Compare
hdgarrood
reviewed
Nov 19, 2020
| @@ -1,4 +1,7 @@ | |||
| module Data.Array.NonEmpty.Internal (NonEmptyArray) where | |||
| -- | This module exports the `NonEmptyArray` constructor, which can be | |||
There was a problem hiding this comment.
I think it might be worth discouraging this module’s use a bit more, by adding a disclaimer that this module is not intended for public use and its API may change at any time, and a breaking change won’t be reflected in the version number?
There was a problem hiding this comment.
What do you think of this, with some bold all caps and newlines to let the disclaimer breath:
It could be nice of Pursuit to display a warning on internal modules, so we can have some CSS on top and we don’t have to synchronize them across packages.
thomashoneyman
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replace some usages of
unsafeCoerce, not bycoercelike I suggested in #181 (comment) but by matching on and applying theNonEmptyArrayconstructor itself as done in purescript/purescript-strings#130. I also adapted the comments from the other pull request.