-
Notifications
You must be signed in to change notification settings - Fork 70
Update to v0.14.0-rc3 #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Includes #176 |
related #183 |
We could replace some uses of unsafeCoerce by Safe.Coerce.coerce in the implementations of Data.Array.NonEmpty.unsafeFromArray, Data.Array.NonEmpty.toArray and Data.Array.groupBy. This requires the NonEmptyArray constructor to be in scope so we should be careful not to re-export it from Data.Array.NonEmpty. Sadly we can’t remove the last unsafeCoerce from Data.Array.unsafeFromArrayF implementation without strengthening its type with a |
@JordanMartinez I've included #183 . Do we want to include suggestions by @kl0tl here too? |
I think we should do @kl0tl's suggestions in a separate PR. They aren't strictly needed to update this library to v0.14.0, but are welcome improvements. |
@paluh All dependencies are now satisfied again. We're still getting an error due to the following line:
We just need to delete the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI now builds. I've also looked through the changes made and have verified that no unicode syntax is being used.
We'll need a second approval before we can merge. Once merged, this will unblock purescript-transformers
.
Backlinking to purescript/purescript#3942