Add is_dashboard_ready function + update unit test #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianZaccaria
force-pushed
the
update-wait-ready
branch
2 times, most recently
from
f397cca to
53b4f98
Compare
Bobbins228
requested changes
Aug 21, 2023
MichaelClifford
requested changes
Aug 30, 2023
src/codeflare_sdk/cluster/cluster.py
Outdated
Comment on lines
222
to
228
| try: | ||
| response = requests.get(self.cluster_dashboard_uri(), timeout=5) | ||
| if response.status_code == 200: | ||
| return True | ||
| except requests.RequestException: | ||
| pass | ||
| return False |
There was a problem hiding this comment.
Does this need to be a try/except? requests.get() should always return some status_code, right?
Can we change it to be a bit simpler:
response = requests.get(self.cluster_dashboard_uri(), timeout=5)
if response.status_code == 200:
return True
else:
return False
|
This will also need a rebase |
ChristianZaccaria
force-pushed
the
update-wait-ready
branch
3 times, most recently
from
06d7ffe to
926e7db
Compare
ChristianZaccaria
force-pushed
the
update-wait-ready
branch
from
926e7db to
f2ad521
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MichaelClifford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Closes #314
What changes have been made
is_dashboard_readyfunction that is used to check for the dashboard's availability. This is done by sending a request to the Dashboard URI, where if status code equals 200 we returnTrue.wait_readyfunction to ensure that both the cluster and the dashboard are operational.Verification steps
I updated the unit tests to reflect these changes on the
wait_readyfunction. All tests are passing.Checks