-
Notifications
You must be signed in to change notification settings - Fork 54
Update wait_ready() behavior (or add a separate check for dashboard accessibility) #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Maxusmusti Hi Mustafa, I created a PR for this issue, however, I'm not entirely sure how to test it. I brought up the cluster with the Thanks in advance! |
Sorry, just saw this. I'll check out the PR, thanks! |
@ChristianZaccaria the only other thing I would do is check in with @KPostOffice to make sure that this update will work alongside his dashboard authentication updates, and if not, sync on what changes need to be made on either end to make the two updates compatible |
Great call, I will sync in with him asap. Thanks @Maxusmusti ! |
@Maxusmusti I just synced with Kevin, he says he will make the changes on his end to make it work with the changes here. Let me know if there is anything you would like me to change or improve on my PR. |
WHY
Currently, there is a gap between when the RayCluster itself is ready (and
cluster.wait_ready()
completes), and when the dashboard is accessible (happens a couple seconds later at most). This means that CI or scripts where job submission is performed immediately afterwait_ready()
has a small chance to fail, depending on how long the dashboard takes to be ready.WHAT
Either wait_ready has to wait for the dashboard to be ready, or we can add a second function that waits for dashboard availability. Anything that can be used in CI/scripts to block until job submission is possible.
The text was updated successfully, but these errors were encountered: