Skip to content

change additionall to additional #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

vaibssingh
Copy link
Contributor

@vaibssingh vaibssingh commented Jul 6, 2023

This fixes the spelling issue with additional being spelled as additionall in ipynb files. Verified by running grep -R additionall *

Fix #197

@jbusche
Copy link
Contributor

jbusche commented Jul 6, 2023

Sure - It looks great! I'm going to quick run it in a notebook, see how it looks, but should be good...

Copy link
Contributor

@jbusche jbusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@MichaelClifford
Copy link
Collaborator

@vaibssingh can you make sure to run pre-commit locally, and then submit another commit.

https://github.com/project-codeflare/codeflare-sdk#pre-commit

@vaibssingh
Copy link
Contributor Author

@MichaelClifford Done!

@vaibssingh vaibssingh changed the title change additionall to addtional change additionall to additional Jul 9, 2023
@MichaelClifford
Copy link
Collaborator

@vaibssingh Hey Looks good, Can you please rebase? Then it will be good to merge.

@vaibssingh
Copy link
Contributor Author

@MichaelClifford Done 👍🏽

@MichaelClifford
Copy link
Collaborator

@vaibssingh this commit history doesn't look right. Did you do git fetch upstream,get rebase upstream/main and then get push --force to your feature branch?

This looks like you merged some code instead of rebasesing your commit on the latest upstream master.

@vaibssingh
Copy link
Contributor Author

vaibssingh commented Jul 13, 2023

Hey @MichaelClifford , no I didn't do anything of that sort. I git pull origin main on my branch and resolved the conflicts and then pushed again. That may be the reason it is showing the commit history in my branch even though the actual changes are only in 3 files.

Do you need me to delete this branch and open a new PR?

@MichaelClifford
Copy link
Collaborator

You could probably still salvage it by reverting to an earlier state, pulling in the new upstream changes then adding your commit via a --force-push.

This PR should really only have 1 commit "change additionall to addtional" on top of the most recent commits on the upstream main.

@vaibssingh
Copy link
Contributor Author

Hey @MichaelClifford , thanks for your help. Have fixed the commit history 😄
Let me know if there is something else that needs to be done here.

Copy link
Collaborator

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @vaibssingh

LGTM

@MichaelClifford MichaelClifford merged commit 5c69c3c into project-codeflare:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo "additionall" Instead of "additional" in the Demo Notebooks
3 participants