-
Notifications
You must be signed in to change notification settings - Fork 54
change additionall to additional #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change additionall to additional #198
Conversation
Sure - It looks great! I'm going to quick run it in a notebook, see how it looks, but should be good... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you!
@vaibssingh can you make sure to run pre-commit locally, and then submit another commit. https://github.com/project-codeflare/codeflare-sdk#pre-commit |
@MichaelClifford Done! |
@vaibssingh Hey Looks good, Can you please rebase? Then it will be good to merge. |
@MichaelClifford Done 👍🏽 |
@vaibssingh this commit history doesn't look right. Did you do This looks like you merged some code instead of rebasesing your commit on the latest upstream master. |
Hey @MichaelClifford , no I didn't do anything of that sort. I Do you need me to delete this branch and open a new PR? |
You could probably still salvage it by reverting to an earlier state, pulling in the new upstream changes then adding your commit via a --force-push. This PR should really only have 1 commit "change additionall to addtional" on top of the most recent commits on the upstream main. |
Hey @MichaelClifford , thanks for your help. Have fixed the commit history 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @vaibssingh
LGTM
This fixes the spelling issue with additional being spelled as additionall in ipynb files. Verified by running
grep -R additionall *
Fix #197