Skip to content

Typo "additionall" Instead of "additional" in the Demo Notebooks #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbusche opened this issue Jul 6, 2023 · 3 comments · Fixed by #198
Closed

Typo "additionall" Instead of "additional" in the Demo Notebooks #197

jbusche opened this issue Jul 6, 2023 · 3 comments · Fixed by #198
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@jbusche
Copy link
Contributor

jbusche commented Jul 6, 2023

There's a small typo in the Demo Notebooks. Might be a good first issue for someone.

grep -R additionall *

demo-notebooks/guided-demos/3_basic_interactive.ipynb:    "#install additionall libraries that will be required for model training\n",
demo-notebooks/guided-demos/notebook-ex-outputs/3_basic_interactive.ipynb:    "#install additionall libraries that will be required for model training\n",
demo-notebooks/interactive/hf_interactive.ipynb:    "#install additionall libraries that will be required for this training\n",
@jbusche jbusche added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jul 6, 2023
@vaibssingh
Copy link
Contributor

Hey @jbusche, can I take this up?
Since I don't see any documentation on how to contribute, I will be forking the repo and creating a PR from a fix branch to this repo. Is that okay?

@jbusche
Copy link
Contributor Author

jbusche commented Jul 6, 2023

Hi @vaibssingh, that sounds great... thanks! Let me know if you have any troubles or questions, will try to help.

@vaibssingh
Copy link
Contributor

@jbusche PR created. Let me know if there is anything else needed before you can merge it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants