(fix) - HMR and Typescript #1395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
commented
Sep 1, 2020
| @@ -36,14 +36,6 @@ async function clientConfig(env) { | |||
| polyfills: resolve(__dirname, './polyfills'), | |||
| }; | |||
|
|
|||
| if (!isProd) { | |||
| entry.bundle = [ | |||
There was a problem hiding this comment.
Removed the unneeded devServers
There was a problem hiding this comment.
Does this automatically get added by the plugin / config option?
There was a problem hiding this comment.
This is part of the DevServer.hot option
| @@ -73,7 +73,6 @@ async function devBuild(env) { | |||
|
|
|||
| let c = Object.assign({}, config.devServer, { | |||
| stats: { colors: true }, | |||
| hot: !env.refresh, | |||
There was a problem hiding this comment.
Enabled the hot-server which we use as a base
Co-authored-by: Jason Miller <[email protected]>
JoviDeCroock
force-pushed
the
fix-prefersh
branch
from
02f7aa1 to
cfa7526
Compare
marvinhagemeister
approved these changes
Sep 2, 2020
| @@ -25,7 +25,7 @@ const cleanFilename = (name) => | |||
| ); | |||
|
|
|||
| async function clientConfig(env) { | |||
| const { isProd, source, src, refresh, cwd /*, port? */ } = env; | |||
| const { isProd, source, src, cwd /*, port? */ } = env; | |||
There was a problem hiding this comment.
We should probably remove any mentions of the --refresh flag in the Readme too👍
There was a problem hiding this comment.
it still works, just removed from the clientConfig and now exclusively present in the devConfig
reznord
approved these changes
Sep 2, 2020
|
Thank you for giving this issue your attention! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows the exclude of the Babel.overrides doesn't work making transformations not apply correctly. We had multiple copies of the devServer present and some of them hot others not which make WDS confused.
I need to accurately test this PR a bit more, tested on Windows and it works now need to do it on a UNIX machine.