Skip to content

Removed explicit webpack entries in dev #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Removed explicit webpack entries in dev #1388

wants to merge 1 commit into from

Conversation

jameshartig
Copy link

What kind of change does this PR introduce?

Bigfix to remove duplicate requires for webpack-dev-server/client which end up causing unnecessary traffic and errors.

Did you add tests for your changes?

No tests were added

Summary

Fixes #1387

Does this PR introduce a breaking change?

No

Other information

According to webpack/webpack-dev-server#711 we don't need to explicitly include these entries as they are added automatically.

@jameshartig
Copy link
Author

jameshartig commented Aug 26, 2020

Looks like tests failed because of:

preact-cli:   ● preact create › should have 'apple-touch-icon' meta tag
preact-cli:     expect(received).toEqual(expected) // deep equality
preact-cli:     Expected: true
preact-cli:     Received: false

but I see other PRs with the same failure. Is that just a flaky test?

According to webpack/webpack-dev-server#711 we don't need to explicitly
include these entries as they are added automatically.

Fixes #1387
@rschristian
Copy link
Member

rschristian commented Sep 4, 2020

Looks like this change was implemented in #1395, you're probably good to close this.

@jameshartig
Copy link
Author

@ryanchristian4427 yep, looks like it.

@jameshartig jameshartig closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack-dev-server/client required twice and second time without correct options
2 participants