Skip to content

Pecl 8.4 tracing JIT crash #17003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danog opened this issue Nov 30, 2024 · 4 comments
Closed

Pecl 8.4 tracing JIT crash #17003

danog opened this issue Nov 30, 2024 · 4 comments

Comments

@danog
Copy link
Contributor

danog commented Nov 30, 2024

Description

Running pecl install xdebug-beta in the image built through https://github.com/danog/jit_bugs/ fails with the following assertion (at least on arm64):

php: ext/opcache/jit/zend_jit_trace.c:8748: int zend_jit_trace_exit(uint32_t, zend_jit_registers_buf *): Assertion `((execute_data)->opline) >= ((execute_data)->func)->op_array.opcodes && ((execute_data)->opline) < ((execute_data)->func)->op_array.opcodes + ((execute_data)->func)->op_array.last' failed.

ping @dstogov / @nielsdos

PHP Version

nightly

Operating System

No response

@nielsdos
Copy link
Member

nielsdos commented Nov 30, 2024

I searched and found we have an old bug report that also hit the exact same assertion, but with a standalone reproducer: #9011
Tentatively making this verified, if the old bug report is fixed we can reverify if this was a duplicate or not.

@nielsdos
Copy link
Member

Actually, while debugging the other issue I start to believe that they might be not related because the other is Windows-specific I think.

dstogov added a commit to dstogov/php-src that referenced this issue Dec 3, 2024
dstogov added a commit to dstogov/php-src that referenced this issue Dec 3, 2024
@dstogov dstogov closed this as completed in c5ce74c Dec 3, 2024
dstogov added a commit that referenced this issue Dec 3, 2024
* PHP-8.4:
  Fix GH-17003: Pecl 8.4 tracing JIT crash (#17032)
@danog
Copy link
Contributor Author

danog commented Dec 3, 2024

Thanks for the fixes @dstogov! Do you think you could merge them into the 8.4.2 branch?

@dstogov
Copy link
Member

dstogov commented Dec 4, 2024

Do you think you could merge them into the 8.4.2 branch?

I think the fix is going to be released only with 8.4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants