Skip to content

8.4 function JIT bug #16985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danog opened this issue Nov 28, 2024 · 6 comments
Closed

8.4 function JIT bug #16985

danog opened this issue Nov 28, 2024 · 6 comments

Comments

@danog
Copy link
Contributor

danog commented Nov 28, 2024

Description

Description

Running:

bugs/psalm_function.sh /app/tests/ConstantTest.php

in https://github.com/danog/jit_bugs/ causes a test failure only with function JIT on x86-64-v4

ping @dstogov

PHP Version

nightly

Operating System

No response

@danog
Copy link
Contributor Author

danog commented Nov 28, 2024

There are also JIT-only failures in tests/ListTest.php, tests/ArrayAssignmentTest.php

@nielsdos
Copy link
Member

nielsdos commented Nov 29, 2024

I think this has the same root cause as #16984.
I ran all 3 tests, and the difference in expected vs actual output was very alike to the one in #16984.
So I applied the patch from #16984 (comment) and the issues are all gone now.
I'm marking this as a duplicate, but keeping it open until Dmitry figured out the details of the issue.

@dstogov
Copy link
Member

dstogov commented Dec 2, 2024

Fixed via 03bb112 together with #16984

@dstogov dstogov closed this as completed Dec 2, 2024
@danog
Copy link
Contributor Author

danog commented Dec 2, 2024

@dstogov Awesome! Could you also take a look at #16996, #17003?

@dstogov
Copy link
Member

dstogov commented Dec 2, 2024

yeah, they are on my list

@nielsdos
Copy link
Member

nielsdos commented Dec 2, 2024

Interesting, thanks for explaining the issue and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants