Skip to content

TST/DEV: remove geopandas downstream test + remove from environment.yml #50008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

StefanieSenger
Copy link
Contributor

@StefanieSenger StefanieSenger commented Dec 2, 2022

See #49994 for context

@MarcoGorelli
Copy link
Member

thanks @StefanieSenger - can you run the pre-commit checks too please? check the contributing guide for how

@StefanieSenger
Copy link
Contributor Author

StefanieSenger commented Dec 2, 2022

Hey @MarcoGorelli, thanks for coming back to me. I had run the pre-commit tests on environment.yml and pandas/tests/test_downstream.py, but but unfortunately didn't notice that one of the tests didn't pass:

Generate pip dependency from conda......................................................................Failed
- hook id: pip-to-conda
- files were modified by this hook

This explains, why geopandas is still listed in requirements-dev.txt and didn't autogenerate from the .yml file, I suppose.
I think I should now investigate why that happened, but I'm a bit lost here, I need to admit. Any advice?

@MarcoGorelli
Copy link
Member

you just need to stage and commit again:

git add -u
git commit -m 'your commit message goes here'

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @StefanieSenger

@phofl phofl added Dependencies Required and optional dependencies Sprints Sprint Pull Requests labels Dec 2, 2022
@jorisvandenbossche jorisvandenbossche changed the title removed geopandas from environment, see https://github.com/noatamir/p… TST/DEV: remove geopandas downstream test + remove from environment.yml Dec 2, 2022
@jorisvandenbossche
Copy link
Member

@StefanieSenger I updated the title of the PR to something more descriptive (the title is used for the resulting commit message)

@StefanieSenger
Copy link
Contributor Author

@MarcoGorelli @jorisvandenbossche Awesome, thanks you much for your support! :)

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Dec 2, 2022
@MarcoGorelli MarcoGorelli merged commit 3377a6d into pandas-dev:main Dec 2, 2022
@StefanieSenger StefanieSenger deleted the removing_geopandas_dependency branch December 2, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies Sprints Sprint Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants