-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TST/DEV: remove geopandas downstream test + remove from environment.yml #50008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST/DEV: remove geopandas downstream test + remove from environment.yml #50008
Conversation
thanks @StefanieSenger - can you run the pre-commit checks too please? check the contributing guide for how |
Hey @MarcoGorelli, thanks for coming back to me. I had run the pre-commit tests on
This explains, why geopandas is still listed in requirements-dev.txt and didn't autogenerate from the .yml file, I suppose. |
you just need to stage and commit again:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks @StefanieSenger
@StefanieSenger I updated the title of the PR to something more descriptive (the title is used for the resulting commit message) |
@MarcoGorelli @jorisvandenbossche Awesome, thanks you much for your support! :) |
See #49994 for context