-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DEV: remove geopandas from the environment.yml file #49994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for working on this @mroeschke you'd said you wanted the environment to enable people to run anything - should this single downstream test be removed? |
Hi @StefanieSenger - did you close this by accident? I think it looks right, I just wanted to double-check with Matthew whether we should also remove the downstream test or whether this is fine as-is |
@MarcoGorelli I must have, though I didn't realise I did ... I'd like to keep it open. Sorry, was my first ever open source contribution. |
Yeah I would be partial to be consistent and remove geopandas everywhere if we also want to remove it from the |
@StefanieSenger could you remove it from the environment.yml again? Additionally, you can delete the test |
Specifically for geopandas, I think we can indeed remove the test as well, and then the concern of not having all optional test dependencies installed is also gone (geopandas runs its CI with pandas main, so that should catch any potential compatibility issue relative fast as well). For the more general issue about other dependencies in little usage in environment.yml, I opened #49998 |
@StefanieSenger if you want to reopen the PR, you will first have to "restore" the branch (there should be a button somewhere in the UI) |
Thanks for the instructions and the beginner friendly atmosphere. I will do this some time today. |
closes #DEV: remove geopandas from the environment.yml file noatamir/pyladies-berlin-sprints#9
All code checks passed.
Added an entry in the latest
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.