TYP: activate Check for missing error codes #36088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Sep 3, 2020
ci/code_checks.sh
Outdated
| # invgrep -R --include="*.py" -P '# type: ignore(?!\[)' pandas | ||
| # RET=$(($RET + $?)) ; echo $MSG "DONE" | ||
| MSG='Check for missing error codes with # type: ignore' ; echo $MSG | ||
| invgrep -R --include="*.py" -P '# type: ignore(?!\[)' pandas |
There was a problem hiding this comment.
should we check for # type:ignore without the space? we have one of those in plotting._matplotlib.core
There was a problem hiding this comment.
i've updated the check to account for optional space. We could also consider preventing that pattern.
|
thanks @simonjayhawkins |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #35311