TYP: Add MyPy Error Codes #35311
TYP: Add MyPy Error Codes #35311
Conversation
simonjayhawkins
added
Code Style
|
@WillAyd have added a code-check to enforce this but may not be able to enable until we bump mypy due a bug in mypy not suppressing some additional notes, so have just commented out the code check for now |
| @@ -109,3 +109,4 @@ dependencies: | |||
| - pip: | |||
| - git+https://github.com/pandas-dev/pydata-sphinx-theme.git@master | |||
| - git+https://github.com/numpy/numpydoc | |||
| - pyflakes>=2.2.0 | |||
There was a problem hiding this comment.
I think this is available from conda?
There was a problem hiding this comment.
I'll give it a go on the CI, IIRC I had issues locally with conda but later found an issue in the environment. conda list showed 2.2.0 but flake8 was still using 2.1.1
There was a problem hiding this comment.
conda doesn't like it.
| @@ -121,7 +121,15 @@ def stringify_path( | |||
| """ | |||
| if hasattr(filepath_or_buffer, "__fspath__"): | |||
| # https://github.com/python/mypy/issues/1424 | |||
| return filepath_or_buffer.__fspath__() # type: ignore | |||
| # error: Item "str" of "Union[str, Path, IO[str]]" has no attribute | |||
There was a problem hiding this comment.
What criteria are you using to include a comment or not?
There was a problem hiding this comment.
Hopefully, always. it makes it much easier when browsing the code for type: ignores to remove. e.g. #35344
While adding the error messages here, it was immediately apparent that those ignores removed in #35344 were masking another issue. If this was already merged to master, the error message would be in the diff (as deleted) for #35344 and make the intent of the changes more clear and hence easier to review imo.
This reverts commit 0cddba7.
|
@WillAyd gentle ping! |
|
Thanks @simonjayhawkins |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff