CLN: Removed Unnecessary Conditionals in groupby_helper #19734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
changed the title
WillAyd
changed the title
|
Same Travis failures we've been having recently - appear unrelated to change |
|
thanks @WillAyd even if this were slower it reduces code complexity which is good. |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffASV results are pretty inconsistent but I couldn't find anything directly related from this change. Of the marks below, only
maxwas touched by this change, and that doesn't appear consistently in the resultsbefore after ratio [2fdf1e25] [458210c1] + 155±1μs 173±4μs 1.12 groupby.GroupByMethods.time_method('float', 'max') + 324±1μs 361±5μs 1.12 groupby.GroupByMethods.time_method('float', 'median') - 722±5μs 638±8μs 0.88 groupby.GroupByMethods.time_method('int', 'cumprod') - 540±10μs 463±1μs 0.86 groupby.GroupByMethods.time_method('int', 'cummax') - 551±20μs 459±1μs 0.83 groupby.GroupByMethods.time_method('int', 'cummin') - 1.17±0.1ms 475±7μs 0.40 groupby.GroupByMethods.time_method('float', 'sem')