fix: replace label selector mock server test with IT #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is what the previous test was covering covered in other tests? |
metacosm
requested changes
Aug 18, 2022
| @Version("v1") | ||
| @ShortNames("lst") | ||
| public class LabelSelectorTestCustomResource | ||
| extends CustomResource<Void, LabelSelectorTestCustomResourceStatus> |
There was a problem hiding this comment.
Why create a status class when it's not used anywhere and empty?
There was a problem hiding this comment.
Good point, fixed. (I think I had an issue with this in the past when status was void, but not anymore)
csviri
force-pushed
the
label-filter-it
branch
from
b1349ba to
fcc4121
Compare
Yes it should. |
csviri
force-pushed
the
label-filter-it
branch
from
fcc4121 to
7fc0ee8
Compare
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
approved these changes
Aug 24, 2022
metacosm
approved these changes
Aug 24, 2022
csviri
added a commit
that referenced
this pull request
Aug 25, 2022
csviri
added a commit
that referenced
this pull request
Aug 30, 2022
csviri
added a commit
that referenced
this pull request
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the former test was doing actually more than it should be. So this is a replacement but also change in scope.