Skip to content

Replace CustomResourceSelectorTest with an Integration Test #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csviri opened this issue Jul 25, 2022 · 0 comments · Fixed by #1375
Closed

Replace CustomResourceSelectorTest with an Integration Test #1366

csviri opened this issue Jul 25, 2022 · 0 comments · Fixed by #1375
Assignees
Milestone

Comments

@csviri
Copy link
Collaborator

csviri commented Jul 25, 2022

This test is only one that uses the mock API server and adding additional overhead and complexity for test maintenance, while could be replaced with an integration test.

@csviri csviri added this to the 3.2 milestone Jul 25, 2022
@csviri csviri linked a pull request Jul 26, 2022 that will close this issue
@csviri csviri closed this as completed Aug 26, 2022
@csviri csviri self-assigned this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant