add support for python ABCs #4547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -960,6 +961,12 @@ def _can_coerce_all(dtypelist, start=0): | |||
| thisind += 1 | |||
| return None | |||
|
|
|||
| def _register_types(): | |||
| numbers.Integral.register(integer) | |||
There was a problem hiding this comment.
Not sure about this. Integral subtypes Rational and should have numerator and denominator properties. I don't think we have those (yet).
|
The two commits can be squashed into one, which should begin |
|
So, now we have numerator and denominator, too. |
| @@ -4030,6 +4059,9 @@ initialize_numeric_types(void) | |||
| PyVoidArrType_Type.tp_as_mapping = &voidtype_as_mapping; | |||
| PyVoidArrType_Type.tp_as_sequence = &voidtype_as_sequence; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
One blank line would suffice ;)
|
That was fast. LGTM. Please add a note to the enhancements section of |
Beginning with version 2.6, python supports abstract base classes, which contain a class hierarchy for numbers. This class hierarchy is very similar to the one of numpy, so it is very easy to register the numpy type hierarchy with the python type hierarchy. This patch adds those registrations and also adds unit tests for it.
numbers.Integral types are supposed to have a numerator and denominator attribute. This adds those two trivial attributes.
|
Merged, thanks @tecki. |
This was referenced Mar 25, 2014
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning with version 2.6, python supports abstract base classes,
which contain a class hierarchy for numbers. This class hierarchy is
very similar to the one of numpy, so it is very easy to register
the numpy type hierarchy with the python type hierarchy.
This pull request adds those registration and test cases for it.