Skip to content

Type checking is to strict #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MuellerSeb opened this issue May 17, 2021 · 1 comment · Fixed by #20
Closed

Type checking is to strict #15

MuellerSeb opened this issue May 17, 2021 · 1 comment · Fixed by #20
Assignees
@MuellerSeb
Labels
bug Something isn't working
Milestone
v1.1

Comments

@MuellerSeb
Copy link
Member

Variable type can be integer and float depending on the given numpy array.

welltestpy/welltestpy/data/varlib.py

Line 124 in 5bdf033

if np.asanyarray(value).dtype == np.float:

This routine should recognize all numpy subtypes of float and int.
@MuellerSeb MuellerSeb added the bug Something isn't working label May 17, 2021
@MuellerSeb MuellerSeb self-assigned this May 17, 2021
@MuellerSeb
Copy link
Member Author

Numpy works well with the numbers module of python:
numpy/numpy#4547

So we should use this for checking.

See: https://stackoverflow.com/a/62055141/6696397

@MuellerSeb MuellerSeb added this to the v1.1 milestone Jul 27, 2021
@MuellerSeb MuellerSeb mentioned this issue Jul 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MuellerSeb MuellerSeb

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

Bugfix: loading steady pumping test was not possible GeoStat-Framework/welltestpy
1 participant
@MuellerSeb