Skip to content

사다리 게임 1단계 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2018
Merged

사다리 게임 1단계 #3

merged 2 commits into from
Nov 16, 2018

Conversation

lalwr
Copy link

@lalwr lalwr commented Nov 15, 2018

No description provided.

javajigi
javajigi requested changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@javajigi javajigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구현 깔끔하게 잘 했네요. 👍
피드백 남겼어요

src/main/java/domain/ladder/Line.java Outdated

public class Line {

ArrayList<Boolean> points;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private

src/main/java/domain/ladder/Line.java Outdated

ArrayList<Boolean> points;

public Line(ArrayList<Boolean> points) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가능하면 구현체보다는 List와 같은 인터페이스 기반으로 구현한다.

src/main/java/domain/ladder/RandomPoint.java Outdated

private ArrayList<Boolean> points = new ArrayList<>();

public ArrayList<Boolean> getRandomPoint(int playerCount){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List

src/main/java/domain/ladder/Line.java

import java.util.ArrayList;

public class Line {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요구사항 중 "사다리 타기가 정상적으로 동작하려면 라인이 겹치지 않도록 해야 한다." 요구사항을 만족하고 있는가?

@javajigi javajigi merged commit 18b45b7 into next-step:lalwr Nov 16, 2018
wotjd243 pushed a commit that referenced this pull request Nov 18, 2019
@naheenosaur @wotjd243
[3주차] 3단계 - 사다리(게임 실행) #3 (#276)
a8002fb 
* refactor : 참여자 리스트 First Class Collection으로 수정

* refactor : 피드백 반영

* refactor : 패키지 이동

* refactor : connectionStrategy 변수 제거

* feature(view) : 결과값 입출력

* refactor : result 값 일급컬렉션으로 분리

* refactor : ladder dto 생성

* refactor : result 유효성 검사 위임

* feat(ladder) : 사다리 이동 경로 확인

* feat(ladder) : 결과값 출력

* refactor : 게임 결과 중복 저장 제거, ladder 에 종료 index 추가

* refactor : ladder게임 진행 상황을 line이 소유하도록 수정, 출력시 dto다시 제거

* refactor : 일급객체 반환

* refactor : Connection 분리
nokchax added a commit to archive-nokchax/java-ladder that referenced this pull request May 29, 2020
@nokchax
Step3 (next-step#3)
e06e6a6 
* feat : add prizes string array from console input

* feat : add object util to check object null and throw exception

* refactor : rename method

* feat : make ladder game init info init with player and prize init info

* fix : fix null check fail code

* feat : make prize, and prizes and test

* test : add mover at foot step enum and implements

* refactor : rename method

* test : take ladder to move from one column to another one

* test : take a ladder one step test and implements

* test : take ladder test and implements

* test : take ladder result test and implements

* refactor : repackaging

* feat : player and prize implements

* feat : match result get prize too

* feat : mission complete

* refactor : rename

* test : players class test

* test : prize class test

* test : prizes class test

* test : player and prize test

* chore : arrange code

* chore : change access modifier

* refactor : method extract

* feat : add ladder size class

* chore : move constructor

* refactor : change test class

* refactor : rename method

* refactor : add newline at the end of file

* debug : update method name
pcspapa added a commit to pcspapa/java-ladder that referenced this pull request Aug 24, 2020
@pcspapa
feat: 조립하기
61106dc 
사다리 높이 입력으로 변경
조립하기

Closes next-step#3, next-step#4
parkeeseul pushed a commit that referenced this pull request Aug 25, 2020
@pcspapa
2단계 - 사다리(생성) (#556)
d6885da 
* feat: 학습중

* feat: 학습 및 수평선 만들기

학습
하나 만들기 & 랜덤으로 다리 잇기.
여러개 만들기
출력하기.

Closes #1, #2

* refactor: 이름 변경 및 메소드 추출

* feat: 조립하기

사다리 높이 입력으로 변경
조립하기

Closes #3, #4

* refactor: 이름과, 사다리 가운데 정렬

* refactor: 줄바꿈

* refactor: 메시지를 상수로 추출

* refactor: 테스트 통과

* refactor: toString 활용

* feat: 결과 메시지 출력

* refactor: List<Horizon> to Ladder

List<Horizon>, Ladder 각각 구현

* refactor: List<Horizon> to Ladder

List<Horizon> 사용 부분 삭제

* refactor: 리뷰 내용 반영 및 기타

리뷰 내용 반영
UI 컴포넌트를 이용한 rendering
Line, Ladder: 퍼스트 클래스 컬렉션 (rename Horizon to Line)

* refactor: 중복제거
jhest added a commit to jhest/java-ladder that referenced this pull request Nov 24, 2023
@jhest
[step01][optional] requirement next-step#3
8d3c07b
ohtaeg pushed a commit that referenced this pull request Nov 24, 2023
@jhest
1단계 - 스트림, 람다, Optional (#1926)
56356ac 
* [step01][lambda] practice #1

* [step01][lambda] practice #2

* [step01][stream] practice #1

* [step01][stream] practice #2

* [step01][optional] requirement #1

* [step01][optional] requirement #2

* [step01][optional] requirement #3
nno0obb pushed a commit to nno0obb/java-ladder that referenced this pull request Apr 6, 2025
@kakao-bt-7274
[ladder] step1: feedback next-step#3
bc81596
nno0obb pushed a commit to nno0obb/java-ladder that referenced this pull request Apr 6, 2025
@kakao-bt-7274
[ladder] step1: feedback next-step#3
cf89782
testrace pushed a commit that referenced this pull request Apr 10, 2025
@nno0obb @kakao-bt-7274
🚀 2단계 - 사다리(생성) (#2327)
0e69334 
* [ladder] step2: .gitignore

* [ladder] step2: README.md

* [ladder] step1: feedback #1

* [ladder] step1: feedback #2

* [ladder] step1: feedback #3

* [ladder] step2: README.md

* [ladder] step2: init

* [ladder] step2: Height

* [ladder] step2: Name

* [ladder] step2: PointX

* [ladder] step2: Line

* [ladder] step2: NameList

* [ladder] step2: README.md

* [ladder] step2: Ladder

* [ladder] step2: PointX

* [ladder] step2: Board

* [ladder] step2: Typo

* [ladder] step2: Typo

* [ladder] step2: Typo

* [ladder] step2: README.md

* [ladder] step2: feedback #1

* [ladder] step2: feedback #2,3

* [ladder] step2: feedback #4,8

* [ladder] step2: README.md

* [ladder] step2: #5

* [ladder] step2: #6,7

* [ladder] step2: README.md

* [ladder] step2: README.md

* [ladder] step2: #9

* [ladder] step2: #10

* [ladder] step2: README.md

* [ladder] step2: Point, Bridge

* [ladder] step2: README.md

* [ladder] step2: feedback #1

* [ladder] step2: feedback #2,3,4,5,6,7

---------

Co-authored-by: bt.7274(김홍균)/kakao <[email protected]>
nno0obb pushed a commit to nno0obb/java-ladder that referenced this pull request Apr 12, 2025
@kakao-bt-7274
[ladder] step2: feedback next-step#3
dfcac76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javajigi javajigi javajigi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lalwr @javajigi