feat(cli-repl): add support for bracketed paste in REPL MONGOSH-1909 #2328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bracketed paste allows us to receive a copy-pasted piece of mongosh as a single block, rather than interpreting it line-by-line. For now, this requires some monkey-patching of Node.js internals, so a follow-up ticket will include work to upstream support for this into Node.js core.
addaleax
commented
Jan 23, 2025
| @@ -43,7 +43,7 @@ | |||
| "access": "public" | |||
| }, | |||
| "engines": { | |||
| "node": ">=16.15.0" | |||
| "node": ">=18.19.0" | |||
There was a problem hiding this comment.
Minimum version with nodejs/node#47150
addaleax
commented
Jan 24, 2025
| @@ -1510,9 +1540,6 @@ describe('e2e', function () { | |||
|
|
|||
| describe('history file', function () { | |||
| it('persists between sessions', async function () { | |||
| if (process.arch === 's390x') { | |||
| return this.skip(); // https://jira.mongodb.org/browse/MONGOSH-746 | |||
| } | |||
There was a problem hiding this comment.
Drive-by because this is also fixed by the env var fixup in .evergreen/setup-env.sh
gagik
approved these changes
Jan 27, 2025
lerouxb
approved these changes
Jan 27, 2025
|
Since this touches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bracketed paste allows us to receive a copy-pasted piece of mongosh as a single block, rather than interpreting it line-by-line. For now, this requires some monkey-patching of Node.js internals, so a follow-up ticket will include work to upstream support for this into Node.js core.