Streamable Http - clean up server memory streams #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhosmer-ant
previously approved these changes
May 1, 2025
src/mcp/server/streamable_http.py
Outdated
| await write_stream.aclose() | ||
| except Exception as e: | ||
| logger.debug(f"Error closing streams: {e}") | ||
| pass |
| await self._request_streams[request_id][0].aclose() | ||
| await self._request_streams[request_id][1].aclose() | ||
| except Exception as e: | ||
| logger.debug(f"Error closing memory streams: {e}") |
There was a problem hiding this comment.
What exceptions would we expect to see here? I'm slightly worried about swallowing everything, since (I think) aclose() itself shouldn't normally throw anything
| await self._write_stream_reader.aclose() | ||
| if self._write_stream is not None: | ||
| await self._write_stream.aclose() | ||
| except Exception as e: |
There was a problem hiding this comment.
Same q about possibly narrowing down the exceptions we really want to suppress here (maybe all? but just flagging)
…essage-for-related-request
…pr/client-resumability
…essage-for-related-request
…pr/client-resumability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving only one read stream in
_request_streamsis not right as we need to clean up both - read and write streams.