StreamableHttp -- resumability support for servers #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsp-ant
requested changes
Apr 25, 2025
examples/servers/simple-streamablehttp/mcp_simple_streamablehttp/event_store.py
Outdated
Show resolved
Hide resolved
examples/servers/simple-streamablehttp/mcp_simple_streamablehttp/event_store.py
Outdated
Show resolved
Hide resolved
examples/servers/simple-streamablehttp/mcp_simple_streamablehttp/event_store.py
Outdated
Show resolved
Hide resolved
dsp-ant
reviewed
Apr 25, 2025
examples/servers/simple-streamablehttp/mcp_simple_streamablehttp/event_store.py
Outdated
Show resolved
Hide resolved
examples/servers/simple-streamablehttp/mcp_simple_streamablehttp/event_store.py
Outdated
Show resolved
Hide resolved
src/mcp/server/streamableHttp.py
Outdated
Comment on lines
764
to
767
| msg_writer, msg_reader = anyio.create_memory_object_stream[ | ||
| tuple[JSONRPCMessage, str | None] | ||
| ](0) | ||
| self._request_streams[stream_id] = msg_writer |
There was a problem hiding this comment.
will this cause leaking streams and unclosed resources?
There was a problem hiding this comment.
have a separate PR to review all resources and close them: #604
dsp-ant
previously approved these changes
May 2, 2025
src/mcp/server/streamable_http.py
Outdated
Comment on lines
551
to
554
| last_event_id = request.headers.get(LAST_EVENT_ID_HEADER) | ||
| if last_event_id: | ||
| await self._replay_events(last_event_id, request, send) | ||
| return |
There was a problem hiding this comment.
Suggested change
| last_event_id = request.headers.get(LAST_EVENT_ID_HEADER) | |
| if last_event_id: | |
| await self._replay_events(last_event_id, request, send) | |
| return | |
| if last_event_id := request.headers.get(LAST_EVENT_ID_HEADER): | |
| await self._replay_events(last_event_id, request, send) | |
| return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for resumability to servers.
As we already have Typescript client that support resumability, testing it with it and the follow up is to add support for resumability on typescript client.
###How to test:
Start Python example server:
In the new terminal start Typescript client
Follow steps:
start-notifications 10 10escandEnterconnectstart-notifications 10 10- you'll see missing events were replayed and the tool continues to send notificationsstacked on top of #573