Fix crash on OpenBSD due to unsupported TCP KeepAlivePeriod #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this issue was preventing me from working and your commit fixed it. |
|
Any progress on this PR? Anything we can do to help it get merged? Thanks! |
|
Any reason this is not merged? cc: @vishr |
BlackNovaTech
force-pushed
the
openbsd-keepalive
branch
from
c7c8597 to
fa87a5e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1456 +/- ##
==========================================
+ Coverage 84.38% 84.42% +0.04%
==========================================
Files 27 27
Lines 2094 2093 -1
==========================================
Hits 1767 1767
+ Misses 213 212 -1
Partials 114 114
Continue to review full report at Codecov.
|
|
I've rebased the patch onto the last version of master to let all the CI tests run, since they have been fixed since I created this PR. |
vishr
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OpenBSD, when the server would accept it's first connection, it would immediately crash with the message
set tcp 127.0.0.1:8082->127.0.0.1:24032: protocol not available.This is caused by OpenBSD not supporting changing the TCP_USER_TIMEOUT. Instead they only support setting the TCP KeepAlive Intervals through sysctl. (See issues aerogo/aero#10 and deprecrated/net2-rs#82)
This patch reverts one of the error handling cases from #1271, and explicitly ignores so to just use the global default KeepAliveInterval if changing it fails.