Skip to content

Fix unhandled errors #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Conversation

im-kulikov
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #1271 into master will decrease coverage by 0.09%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1271     +/-   ##
=========================================
- Coverage   81.88%   81.78%   -0.1%     
=========================================
  Files          26       26             
  Lines        1932     1933      +1     
=========================================
- Hits         1582     1581      -1     
- Misses        242      243      +1     
- Partials      108      109      +1
Impacted Files Coverage Δ
echo.go 86.95% <33.33%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9e043...26eb8c8. Read the comment docs.

@alexaandru
Copy link
Contributor

LGTM but I do have one question:

Now that we have modules support, things have changed quite a bit:

BEFORE: go get ... would pull the latest master, so if we pushed changes/fixes, people could still fetch them even if we did not cut a release.

NOW: with Go modules support, people using Go modules can only pull tagged releases (well, they can forge a given commit but that is ugly). So what does this mean in practice?!? Do we create release (and a tag) after every single commit? :-) That'll be a bit weird... Thoughts @im-kulikov @vishr ?

@im-kulikov
Copy link
Contributor Author

im-kulikov commented Jan 30, 2019

if someone needs a specific release, he can get it:
go get <url>:@<version>
or
go get <url>:@latest

Master branch is under development, and not for use.. (IMO)..

once we have collected a critical number of fixes, we can prepare a release. there's nothing wrong with that.


I didn't think you'd create a v4 right away

@alexaandru
Copy link
Contributor

Yup, I guess you're right. It's how it worked so far as well. Alright then, merge away please! :)

@im-kulikov
Copy link
Contributor Author

im-kulikov commented Feb 1, 2019

@vishr what you think about PR?

@vishr vishr merged commit bc28fce into labstack:master Feb 1, 2019
@im-kulikov im-kulikov deleted the fix/unhandled-errors branch February 1, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants