This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Navigation: Separate pagecontainer and transitions #7930
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 28, 2015 15:33
This allows transitions to live without navigation Fixes jquery-archivegh-6929 Fixes jquery-archivegh-4022 Fixes jquery-archivegh-7158
Do not assume that calling $.mobile.initializePage() results in a synchronous call to resetActivePageHeight(), because resetActivePageHeight() gets called from a pageshow handler, which may be asynchronous, depending on the implementation of the transition handler for the "none" transition.
This avoids dependence on navigation history
gabrielschulhof
force-pushed
the
4022-separate-pagecontainer-and-transitions
branch
from
c3c5727 to
46002cf
Compare
gabrielschulhof
restored the
4022-separate-pagecontainer-and-transitions
branch
| // Direct focus to the page title, or otherwise first focusable element | ||
| focusPage: function( page ) { | ||
| var autofocus = page.find( "[autofocus]" ), | ||
| pageTitle = page.find( ".ui-title:eq(0)" ); |
There was a problem hiding this comment.
lets just set the var here, and do the find later don't need to needlessly search the whole page if we already found an autofocus element.
|
ok so aside from those couple things i think this looks good |
arschmitz
added
Action: PR needs modification
and removed
Action: PR needs reviewing
labels
gabrielschulhof
added
Action: PR needs reviewing
and removed
Action: PR needs modification
labels
|
@gabrielschulhof if you can fix that one minor thing and rebase 👍 |
arschmitz
added
Action: PR needs modification
Action: Needs Merge
and removed
Action: PR needs reviewing
labels
kapilgarg1996
pushed a commit
to kapilgarg1996/jquery-mobile
that referenced
this pull request
Jun 27, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pagecontainerno longer depends on transitions, providing instant page changes only. Nevertheless, a new extension,pagecontainer.transitionsimplements page change via transition. Transitions no longer need navigation, because$.mobile.focusPage()is moved tohelpersand because they now receive thescrollToposition from whoever initiates the transition, rather than retrieving it themeselves from$.mobile.navigate.historyFixes gh-6929
Fixes gh-4022
Fixes gh-7158