Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Circular reference involving pagecontainer and jquery.mobile.navigation #7158

Closed
gabrielschulhof opened this issue Feb 23, 2014 · 2 comments
Closed

Circular reference involving pagecontainer and jquery.mobile.navigation #7158

gabrielschulhof opened this issue Feb 23, 2014 · 2 comments
Labels
Component: Build

Comments

@gabrielschulhof
Copy link

widgets/pagecontainer →
transitions/handlers→
transitions/concurrent→
transitions/transition→
jquery.mobile.navigation→
widgets/pagecontainer

transitions/transition needs jquery.mobile.navigation, because $.mobile.focusPage resides therein.

The method could be defined in helpers, or even page instead, and we would break this cycle.
@gabrielschulhof
Copy link
Author

This results in an error when you try to write an integration test where you $.testHelper.asyncLoad([ "widgets/pagecontainer" ], [ "jquery.mobile.init" ]);

@gabrielschulhof
Copy link
Author

... such as a possible test for #7148 ...

gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 20, 2015
Transitions: Aquire transition scrollTo data via parameter
6489539 
This avoids dependence on navigation history

Fixes jquery-archivegh-7158
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 20, 2015
Navigation: Move $.mobile.focusPage() into helpers
aa7226a 
This allows transitions to live without navigation

Fixes jquery-archivegh-4022
Fixes jquery-archivegh-7158
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 22, 2015
Navigation: Move $.mobile.focusPage() into helpers
387a921 
This allows transitions to live without navigation

Fixes jquery-archivegh-4022
Fixes jquery-archivegh-7158
@gabrielschulhof gabrielschulhof mentioned this issue Jan 22, 2015
Closed
gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 28, 2015
Navigation: Move $.mobile.focusPage() into helpers
fc37afb 
This allows transitions to live without navigation

Fixes jquery-archivegh-6929
Fixes jquery-archivegh-4022
Fixes jquery-archivegh-7158
kapilgarg1996 pushed a commit to kapilgarg1996/jquery-mobile that referenced this issue Jun 27, 2015
@kapilgarg1996
Navigation: Separate pagecontainer and transitions
bc22155 
Fixes jquery-archivegh-6929
Fixes jquery-archivegh-4022
Fixes jquery-archivegh-7158
Closes jquery-archivegh-7930
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Navigation: Separate pagecontainer and transitions gabrielschulhof/jquery-mobile
1 participant
@gabrielschulhof