This repository was archived by the owner on Jun 8, 2021. It is now read-only.
Fix up cairo interaction extension traits #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove duplicated ContextExt::cairo_surface_create_from_pixbuf(). It already exists as PixbufExt::create_surface() - Rename ContextExt::cairo_draw_from_gl() to draw_from_gl() and take the context as &self - Mark ContextExt::draw_from_gl as unsafe! It takes random integers for GL resources, which are basically like pointers and must be taken care of to be correct and valid. - Change all functions taking a gdk::Window to take a IsA<gdk::Window> - Rename all traits to include the Gdk prefix for preventing naming conflicts. Fixes #308
| @@ -10,11 +10,11 @@ use glib::object::IsA; | |||
| use glib::translate::*; | |||
| use {Rectangle, Window, RGBA}; | |||
|
|
|||
| pub trait SurfaceExt { | |||
| pub trait GdkSurfaceExt { | |||
There was a problem hiding this comment.
It comes from GDK but do we really want to name it like this?
There was a problem hiding this comment.
IMHO yes, as "it comes from GDK"
There was a problem hiding this comment.
Just like we have GtkWindowExt for example
There was a problem hiding this comment.
This is all too complicated for me.
|
@sdroege Thanks, 👍 |
|
@GuillaumeGomez all green |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
already exists as PixbufExt::create_surface()
context as &self
GL resources, which are basically like pointers and must be taken care
of to be correct and valid.
conflicts.
Fixes #308