Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

Clean up ciaro interactions #308

Closed
bilelmoussaoui opened this issue Aug 12, 2019 · 4 comments · Fixed by #312
Closed

Clean up ciaro interactions #308

bilelmoussaoui opened this issue Aug 12, 2019 · 4 comments · Fixed by #312

Comments

@bilelmoussaoui
Copy link
Member

bilelmoussaoui commented Aug 12, 2019 •
edited
Loading

Currently, some methods are implemented as part of the ContextExt which shouldn't be the case.

The PixbufExt isn't loaded on prelude either.
@bilelmoussaoui bilelmoussaoui mentioned this issue Aug 12, 2019
Merged
@sdroege
Copy link
Member

sdroege commented Aug 14, 2019

  • cairo_draw_from_gl() should take the context as &self
  • cairo_surface_create_from_pixbuf() should be removed from ContextExt (it's in PixbufExt where it should be)
  • The traits should get Gdk as prefix of their name to prevent conflicts

@bilelmoussaoui
Copy link
Member Author

Thanks! Will get a MR for this later today

This was referenced Aug 14, 2019
Closed
Closed
@sdroege sdroege mentioned this issue Sep 5, 2019
Merged
@sdroege
Copy link
Member

sdroege commented Sep 5, 2019

Thanks! Will get a MR for this later today

Long day :) I've created #312 for this now, please review if you have some time

@bilelmoussaoui
Copy link
Member Author

Thanks for taking the time to fix it. Completely forgot about it

GuillaumeGomez pushed a commit to gtk-rs/gtk3-rs that referenced this issue Oct 23, 2020
@sdroege
gdk: Fix up cairo interaction extension traits
530e5ec 
- Remove duplicated ContextExt::cairo_surface_create_from_pixbuf(). It
  already exists as PixbufExt::create_surface()
- Rename ContextExt::cairo_draw_from_gl() to draw_from_gl() and take the
  context as &self
- Mark ContextExt::draw_from_gl as unsafe! It takes random integers for
  GL resources, which are basically like pointers and must be taken care
  of to be correct and valid.
- Change all functions taking a gdk::Window to take a IsA<gdk::Window>
- Rename all traits to include the Gdk prefix for preventing naming
  conflicts.

Fixes gtk-rs/gdk#308
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix up cairo interaction extension traits
2 participants
@sdroege @bilelmoussaoui