Skip to content

changed to_title to to_sentence and implemented correct to_title #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 22, 2021
Merged

changed to_title to to_sentence and implemented correct to_title #407

merged 8 commits into from
May 22, 2021

Conversation

aman-godara
Copy link
Member

@aman-godara aman-godara commented May 7, 2021 •
edited by awvwgk
Loading

Status: Code is open for review
Concerning PR: #372

Tasks:

  • implemented correct to_title & changed to_title to to_sentence
  • written/updated tests for both to_title & to_sentence
  • Documentation
  • Added module dependency of stdlib_math on stdlib_kinds in src/Makefile.manual

Closes #372

@aman-godara aman-godara changed the title changed to_title to to_sentence & implemented correct to_title changed to_title to to_sentence and implemented correct to_title May 7, 2021
@awvwgk awvwgk added the reviewers needed This patch requires extra eyes label May 15, 2021
@awvwgk awvwgk requested review from awvwgk, arjenmarkus and jvdp1 May 15, 2021 10:43
awvwgk
awvwgk requested changes May 15, 2021
View reviewed changes
@aman-godara
Copy link
Member Author

Please rerun the workflow once. I don't think there is any error in the code.

@LKedward
Copy link
Member

Please rerun the workflow once. I don't think there is any error in the code.

Yes, this is unrelated to your changes in this PR. It looks like the Makefile is missing a dependency for stdlib_math. Adding the following to Makefile.manual under # Fortran module dependencies (line 57) should fix it:

stdlib_math.o: stdlib_kinds.o

@aman-godara
Copy link
Member Author 

stdlib_math.o: stdlib_kinds.o

Ok!, I will make the necessary changes.

jvdp1
jvdp1 reviewed May 16, 2021
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds good to me.
The specs for to_title must be adapted.
The specs for to_sentece must be added.

@aman-godara aman-godara marked this pull request as ready for review May 21, 2021 18:09
jvdp1
jvdp1 approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Approved pending small suggestions

@awvwgk
Copy link
Member

awvwgk commented May 22, 2021

Thanks for this patch. I'll go ahead and merge.

@awvwgk awvwgk merged commit 1822e3f into fortran-lang:master May 22, 2021
@aman-godara aman-godara deleted the correcting_to_title branch May 22, 2021 10:03
@awvwgk awvwgk removed the reviewers needed This patch requires extra eyes label Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdp1 jvdp1 jvdp1 approved these changes

@awvwgk awvwgk awvwgk approved these changes

@arjenmarkus arjenmarkus Awaiting requested review from arjenmarkus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aman-godara @LKedward @awvwgk @jvdp1