To_Title is corrected

[ChetanKarwa]

The to_title function was not working properly it is working like to_sentence:

input:- this text is some title
earlier output:- This text is some title
expected output:- This Text Is Some Title

I made the necessary changes.
Check it out.

[aman-godara]

Titled version: The first alphabetical character of the input character sequence is transformed to uppercase unless it follows a numeral and the rest of the characters in the sequence are transformed to lowercase.

Please check these comments by arjenmarkus and awvwgk to understand this better : #346 (comment) & #346 (comment)

[ChetanKarwa]

Ok I get that.
That is what we have implemented and written in description but the common implementation is capitalising each word. (There are exceptional words)
Same is implemented in python language and on various online sentence to title convertors.

I have not checked in other languages but I suggest we should also implement to_title the similar way and the current implementation can be called 'to_sentence' or any other name that suits the operation.

Just a suggestion to land on common ground with other languages.

[jvdp1]

I have not checked in other languages but I suggest we should also implement to_title the similar way and the current implementation can be called 'to_sentence' or any other name that suits the operation

I didn't think about it while reading the specs. However, I may agree with this comment. @awvwgk what do you think about it?

[awvwgk]

I just checked python strings and they have both .capitalize() and title(), the current to_title implementation is a version of capitalize under the wrong name. to_sentence would be a better name and we can also have an actual to_title function.

@ChetanKarwa Would you adjust your patch to rename the current to_title function as to_sentence and than we can discuss the actual to_title implementation here?

[ChetanKarwa]

Sure will do that.

[ChetanKarwa]

For now, the PR holds the to_title() function and so I would go forward and implement the to_sentence() separately so that in case we all come down to the conclusion of implementing to_title() this can be used.

[awvwgk]

This could be more general than just spaces, every non-word boundary might trigger capitalization, consider:
to_title(".this.sentence.is.separated.with.dots."), would we expect .This.sentence.is.separated.with.dots. or .This.Sentence.Is.Separated.With.Dots. for a titlecase return value?

[jvdp1]

Hmmm! I am not sure what to expect in such a case. My favor would go to capitalize each word. What do other languages?

[aman-godara]

I checked for python and realised that every character which is not an alphabet triggers capitalization including integers. Python mentions that even apostrophe(') triggers this capitalization which is undesirable. May be we can take an optional set as the argument from the user which will consist of characters the user wants to the trigger capitalization for..

[aman-godara]

I am assigning this task to myself as well.