-
Notifications
You must be signed in to change notification settings - Fork 606
Windows update #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows update #311
Conversation
Whoa, these were originally removed because https://download.docker.com/win/static/stable/x86_64/ stopped having new builds, but it looks like that's changed?? @thaJeztah is that on purpose and going to stay true?? 🙏 |
Ah! You spotted them Yes, Windows builds were disabled at some point because of As to; will they stay? We have no intent to disable them again, but I must admit that I haven't tried the builds myself; working on a 20.10.7 test release right now; if those packages appear, give them a spin as well, and I'd say; go for it |
Ahh, makes sense -- we'll give it a go!
Yeah, this is a good start, although we also need to resurrect some of the bits that were removed in #262 (honestly, the template was an oversight there 😂). I'll take over from here to get this updated with the missing bits. 😅 |
See https://download.docker.com/win/static/stable/x86_64/ 🎉 Co-authored-by: Tianon Gravi <[email protected]>
Haha, what a coincidence. I’m happy that now it will be back. |
variantAliases=( "${versionAliases[@]/%/${variant:+-$variant}}" ) | ||
variantAliases=( "${variantAliases[@]//latest-/}" ) | ||
|
||
sharedTags=() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want shared tags between Windows & Linux too? (like python)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't previously, which is why I didn't here -- I think that was a conscious choice due to the massive differences in their ability to be functional/useful on the different platforms.
Changes: - docker-library/docker@271f58a: Merge pull request docker-library/docker#311 from krystofwoldrich/windows-update - docker-library/docker@01ecb28: Add back Windows variant
Changes: - docker-library/docker@279ba9c: Update 20.10 to 20.10.7 - docker-library/docker@271f58a: Merge pull request docker-library/docker#311 from krystofwoldrich/windows-update - docker-library/docker@01ecb28: Add back Windows variant
Hi guys,
I've needed to use docker on windows image and I've noticed the one in the repo is quite a bit old now.
Changes
Do you think it is welcomed change?
I think the template would deserve the update.
And about the explicite file, I'm not sure if it won't collide with the ci here in the repo.