Skip to content

Windows update #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

krystofwoldrich
Copy link
Contributor

Hi guys,
I've needed to use docker on windows image and I've noticed the one in the repo is quite a bit old now.

Changes

  • So I've updated the windows base image in the template
  • and explicitly added windows version based on current ltsc2019.

Do you think it is welcomed change?

I think the template would deserve the update.
And about the explicite file, I'm not sure if it won't collide with the ci here in the repo.

@tianon
Copy link
Member

tianon commented Jun 1, 2021

Whoa, these were originally removed because https://download.docker.com/win/static/stable/x86_64/ stopped having new builds, but it looks like that's changed?? @thaJeztah is that on purpose and going to stay true?? 🙏

@thaJeztah
Copy link
Contributor

Whoa, these were originally removed because https://download.docker.com/win/static/stable/x86_64/ stopped having new builds, but it looks like that's changed?? @thaJeztah is that on purpose and going to stay true?? 🙏

Ah! You spotted them ☺️😁

Yes, Windows builds were disabled at some point because of <reasons>. Those reasons were no longer there, so when working on some changes in our release pipeline, we decided to "yolo! let's enable them again".

As to; will they stay? We have no intent to disable them again, but I must admit that I haven't tried the builds myself; working on a 20.10.7 test release right now; if those packages appear, give them a spin as well, and I'd say; go for it

@tianon
Copy link
Member

tianon commented Jun 2, 2021

Yes, Windows builds were disabled at some point because of <reasons>. Those reasons were no longer there, so when working on some changes in our release pipeline, we decided to "yolo! let's enable them again".

As to; will they stay? We have no intent to disable them again, but I must admit that I haven't tried the builds myself; working on a 20.10.7 test release right now; if those packages appear, give them a spin as well, and I'd say; go for it

Ahh, makes sense -- we'll give it a go!

I think the template would deserve the update.
And about the explicite file, I'm not sure if it won't collide with the ci here in the repo.

Yeah, this is a good start, although we also need to resurrect some of the bits that were removed in #262 (honestly, the template was an oversight there 😂).

I'll take over from here to get this updated with the missing bits. 😅

@tianon tianon requested a review from yosifkit June 2, 2021 00:30
@krystofwoldrich
Copy link
Contributor Author

Yes, Windows builds were disabled at some point because of <reasons>. Those reasons were no longer there, so when working on some changes in our release pipeline, we decided to "yolo! let's enable them again".
As to; will they stay? We have no intent to disable them again, but I must admit that I haven't tried the builds myself; working on a 20.10.7 test release right now; if those packages appear, give them a spin as well, and I'd say; go for it

Ahh, makes sense -- we'll give it a go!

I think the template would deserve the update.
And about the explicite file, I'm not sure if it won't collide with the ci here in the repo.

Yeah, this is a good start, although we also need to resurrect some of the bits that were removed in #262 (honestly, the template was an oversight there 😂).

I'll take over from here to get this updated with the missing bits. 😅

Haha, what a coincidence. I’m happy that now it will be back.

variantAliases=( "${versionAliases[@]/%/${variant:+-$variant}}" )
variantAliases=( "${variantAliases[@]//latest-/}" )

sharedTags=()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want shared tags between Windows & Linux too? (like python)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't previously, which is why I didn't here -- I think that was a conscious choice due to the massive differences in their ability to be functional/useful on the different platforms.

@yosifkit yosifkit merged commit 271f58a into docker-library:master Jun 2, 2021
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 2, 2021
Changes:

- docker-library/docker@271f58a: Merge pull request docker-library/docker#311 from krystofwoldrich/windows-update
- docker-library/docker@01ecb28: Add back Windows variant
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 2, 2021
Changes:

- docker-library/docker@279ba9c: Update 20.10 to 20.10.7
- docker-library/docker@271f58a: Merge pull request docker-library/docker#311 from krystofwoldrich/windows-update
- docker-library/docker@01ecb28: Add back Windows variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants