Add initial jq-based templating engine #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Oct 14, 2020
generate-stackbrew-library.sh
Outdated
| } | ||
|
|
||
| # sort version numbers with highest first | ||
| #IFS=$'\n'; versions=( $(echo "${versions[*]}" | sort -rV) ); unset IFS |
There was a problem hiding this comment.
We should probably delete this comment and just copy what Go has: https://github.com/docker-library/golang/blob/ee2d52a7ad3e077af02313cd4cd87fd39837412c/generate-stackbrew-library.sh#L26-L27
tianon
reviewed
Oct 14, 2020
versions.sh
Outdated
| export bashbrewArch url | ||
| doc="$( | ||
| jq <<<"$doc" -c '.arches[env.bashbrewArch] = { | ||
| dockerUrl: env.url, |
There was a problem hiding this comment.
Suggested change
| dockerUrl: env.url, | |
| dockerUrl: env.url, |
tianon
reviewed
Oct 14, 2020
versions.sh
Outdated
|
|
||
| # order here controls the order of the library/ file | ||
| for variant in \ | ||
| "" \ |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Oct 15, 2020
Changes: - docker-library/docker@5373612: Merge pull request docker-library/docker#262 from infosiftr/jq-template - docker-library/docker@12d1c27: Add initial jq-based templating engine
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on docker-library/php#1052 and related. Also finally drops
windowssupport from scripts.