Skip to content

2.12 support #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2014
Merged

2.12 support #24

merged 3 commits into from
Jun 23, 2014

Conversation

skyluc
Copy link

@skyluc skyluc commented Jun 20, 2014

Rebased #20 on top of #23 and the 0.1.6-SNAPSHOT branch.

@huitseeker
Copy link

@skyluc are you sure you want to keep #23 open then ?
@daniel-trinh Don't hesitate to ask again for help on this one.

@daniel-trinh
Copy link
Owner

It looks like the org.scalariform references should be updated to com.danieltrinh --

Also, it looks like the 2.11 scala version is still pointing to 2.11-SNAPSHOT:

      <properties>
        <scala.version>2.11.0-SNAPSHOT</scala.version>
        <version.suffix>2_11</version.suffix>
      </properties>

Should that be fixed as part of this merge request?

After I tried making these modifications locally, running mvn -Pscala-2.12.x clean verify -e passed, although I got this warning, not sure if it is relevant:

[WARNING]  Expected all dependencies to require Scala version: 2.12.0-SNAPSHOT
[WARNING]  com.danieltrinh:scalariform.feature:0.1.6-SNAPSHOT requires scala version: 2.12.0-SNAPSHOT
[WARNING]  org.scala-lang.modules:scala-xml_2.11:1.0.2 requires scala version: 2.11.1
[WARNING] Multiple versions of scala libraries detected!

@skyluc
Copy link
Author

skyluc commented Jun 23, 2014

@huitseeker #23 is just a straight-forward fix to align the version numbers

@daniel-trinh the groupId and the version numbers are already fixed in the 0.1.6-SNAPSHOT branch (the branch this pull request is based on). I see more changes needed on these points.

For the warning, not much can be done about it. scala-xml will always depend on a fixed version of Scala, which will different to the -SNAPSHOT version. Right now 2.11-1.0.2 is compatible with Scala 2.12. The Scala team will generate a new version if it breaks.

daniel-trinh added a commit that referenced this pull request Jun 23, 2014
@daniel-trinh daniel-trinh merged commit 36f5c14 into daniel-trinh:0.1.6-SNAPSHOT Jun 23, 2014
@daniel-trinh
Copy link
Owner

I will eventually update the SBT build at some point for 2.12, but that can be done separately from the maven builds for eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants