Adds support for Scala 2.12 #20
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is straight forward, it just sets new version.
The second one is a bit more problematic. The change is to depend on the 'new' scala-xml bundle, instead of only using the package dependency. This is required to be able to load scalariform and multiple versions of Scala in the same OSGi container, like we want to do in Scala IDE.
If an OSGi bundle requires Scala 2.11 and the package scala.xml, and Scala 2.10 is also available, the OSGi container will decide that the bundle depends on both Scala 2.11 and 2.10, which is is impossible.
The practical problem is that this change is not compatible with building scalariform on Scala 2.10.
In Scala IDE, we solve the problem by adding a pre-step to copy the right file for the version of Scala. Unfortunately, we haven't found a better solution, mostly due to an abuse of the Maven lifecycle by Tycho (the Eclipse build maven plugin).